Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solc: remove Z3 version hardcoding #374928

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

solc: remove Z3 version hardcoding #374928

wants to merge 1 commit into from
+3 −5

Conversation

numinit
Copy link
Contributor

@numinit numinit commented Jan 19, 2025 •
edited
Loading

solc compiles with the latest Z3 so we don't need to pull in a specific version.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@numinit
solc: remove Z3 version hardcoding
ee5a842 
solc compiles with the latest Z3.
@numinit numinit mentioned this pull request Jan 19, 2025
Draft
13 tasks
@numinit numinit marked this pull request as draft January 19, 2025 01:05
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 19, 2025
@numinit
Copy link
Contributor Author

numinit commented Jan 19, 2025

Stuck on this after trying to enable the tests to make sure the newer Z3 doesn't break anything:

solc> Testing Python scripts...(B
solc> ..........................................................................E....
solc> ======================================================================
solc> ERROR: test_gas_diff_stats (unittest.loader._FailedTest.test_gas_diff_stats)
solc> ----------------------------------------------------------------------
solc> ImportError: Failed to import test module: test_gas_diff_stats
solc> Traceback (most recent call last):
solc>   File "/nix/store/c9m6yd8fg1flz2j5r4bif1ib5j20a0cy-python3-3.12.8/lib/python3.12/unittest/loader.py", line 396, in _find_test_path
solc>     module = self._get_module_from_name(name)
solc>              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
solc>   File "/nix/store/c9m6yd8fg1flz2j5r4bif1ib5j20a0cy-python3-3.12.8/lib/python3.12/unittest/loader.py", line 339, in _get_module_from_name
solc>     __import__(name)
solc>   File "/build/source/test/scripts/test_gas_diff_stats.py", line 8, in <module>
solc>     from gas_diff_stats import collect_statistics
solc>   File "/build/source/scripts/../scripts/gas_diff_stats.py", line 20, in <module>
solc>     from parsec import generate, ParseError, regex, string, optional
solc> ModuleNotFoundError: No module named 'parsec'
solc> ----------------------------------------------------------------------
solc> Ran 79 tests in 0.015s
solc> FAILED (errors=1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sifmelcara sifmelcara Awaiting requested review from sifmelcara

@lionello lionello Awaiting requested review from lionello

@dbrock dbrock Awaiting requested review from dbrock

@akru akru Awaiting requested review from akru

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@numinit